Add missing l and L suffixes in int32 and int64 printers for both Lin and STM #562
Merged
Conversation
Collaborator
Author
|
Note: The CI summary: all 50 workflows passed |
Collaborator
Author
|
CI summary for merge to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds missing
landLsuffixes inint32andint64printers for bothLinandSTM,which meant that
int32andint64literals couldn't just be copy-pasted into, e.g.,utop.The fix simply forwards the calls to
QCheck.Print.int{32,64}, thereby solving this in one central place.These were furthermore some of the only remaining exceptions to type combinators not relying on
QCheck.Print,thus restoring OCD world order... 🤓
QCheck.Print.int{32,64}were added in 0.24 - but we already have 0.25 as a lower bound, so all should be well.